Zsh Mailing List Archive
Messages sorted by:
Re: A serious bug in execution – where to debug?
- X-seq: zsh-workers 44624
- From: Roman Perepelitsa <roman.perepelitsa@xxxxxxxxx>
- To: Sebastian Gniazdowski <sgniazdowski@xxxxxxxxx>
- Subject: Re: A serious bug in execution – where to debug?
- Date: Wed, 31 Jul 2019 15:34:20 +0200
- Cc: Daniel Shahaf <d.s@xxxxxxxxxxxxxxxxxx>, Zsh hackers list <zsh-workers@xxxxxxx>
- Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=yFV81HANlHIVPc9ajM3AuqIKtKXD6wc/nZEG1A0WNYA=; b=cgWVVYGJt5Gza6q1jhWlBvMHeKITaNY24pix/Y97ASgGRyDJUAgBsY6XUtQx8lqKTC tmMrpQTYT9EpvqHnbQDmfDfpvkgDXF2/zo0aKpPY39fRDP/xlDfD3LZqwuCkp2ifjzpb WN93U0JPvZb1OAT8dsxIzcjILT5zcSC1jxvTO3XcFUfByK0Ki8MWfsOXPck20r9IiqZE OhCZoATb82G4v/xwxrfQSHa8zAwYC17LEeQyds5Nv03LrIc/Hc6m8b8UDKnu2p73kT/4 nA2uz2Po/iOLff3Zunrfzh7bCqBOCGzYEWtUe/0p+k4PRaBm+tKeKlTeewUlXlmm2OCU SiDw==
- In-reply-to: <CAKc7PVCeNC=OE87QECJM=YsnRHbUn4prrYFFFnXqpeoa3gjVbQ@mail.gmail.com>
- List-help: <mailto:firstname.lastname@example.org>
- List-id: Zsh Workers List <zsh-workers.zsh.org>
- List-post: <mailto:email@example.com>
- List-unsubscribe: <mailto:firstname.lastname@example.org>
- Mailing-list: contact zsh-workers-help@xxxxxxx; run by ezmlm
- References: <CAKc7PVCKrg_PnZ6jKLoAwR8XQnswT-Bs2TJA7oefhd_gRtHKUQ@mail.gmail.com> <CAH+w=7ZEukuvaOiBymgJ1nR1TbriEMSxx9L8-=hojxQoKOaRUw@mail.gmail.com> <CAKc7PVCbP5inrfFW3xiphBN5uH3o3ayVRnzzEbybfkp-Y5Fubw@mail.gmail.com> <CAN=4vMqkjK5hPxhhXYwp=4Sj49VfyZgEH06tK0vggnHyddbrsA@mail.gmail.com> <CAKc7PVC6vxkHRvRSQzPGxgOXLOMc-LyJaqA5DmsLXQ5tU8y3Hw@mail.gmail.com> <CAN=4vMo2-w8qEdsgWwZ5C3WE+ZRmBa-c2BxjpZ7NWpvNq_J2tQ@mail.gmail.com> <email@example.com> <CAN=4vMrudHprUE=xb+V7Y+3T6tZvs7wRAe7TbC-BK_Zv+sczUg@mail.gmail.com> <CAKc7PVCo2kTSqgmChp_jL-+fAZ3ytUigRWGnNfMud_-tQyOfirstname.lastname@example.org> <CAN=4vMrTHP5qtS0dJrLJKPc9M3K5DsLTAa78i+W7+Sy4F90YOw@mail.gmail.com> <CAKc7PVAMxstE137buR3vFLkmcHJ9KDg0WDGB95_3_8ZXNvh-Gg@mail.gmail.com> <CAN=4vMpHzHVyrs94QYPwjf+Bu0h_PJABsG14SxgQGEq1uHqU4g@mail.gmail.com> <CAKc7PVCeNC=OE87QECJM=YsnRHbUn4prrYFFFnXqpeoa3gjVbQ@mail.gmail.com>
On Wed, Jul 31, 2019 at 3:10 PM Sebastian Gniazdowski
> This particular case will be solved if the plugin will use
> add-zle-hook-widget instead of wrapping (support for this isn't yet in
> zplugin, but it'll be there soon).
Unfortunately, using add-zle-hook-widget is no-no. If you use it while
other plugins are still wrapping widgets old-school, you can cause
infinite loops. All plugins have to be switched to add-zle-hook-widget
at the same time, which is pretty much impossible. Hopefully someone
will care enough to fix add-zle-hook-widget but the benefits are
difficult to see. Wrapping widgets works fine. It breaks zplugin's
unloading code but the same can be said about pretty much everything.
> To sum up, your opinion is a mathematical-like proof that:
> * You cannot implement an unloading that just works as expected.
> While my opinion is a practical-view -like point that:
> * You can often get good results with unloading, just try & test it
> first with the plugin that you need to unload.
Both statements are true.
What I don't like is the implication of offering a
maybe-works-maybe-doesn't unloading mechanism. It creates an
expectation that plugins must be unloadable not via their public APIs
but through brutal and unceremonious deletion of their internal
parameters, widgets and so on. If something breaks during unloading,
users may not even realize they've grown to rely on hacks and that
their shell configuration is unsupported. They can reasonably reach
out to the "malfunctioning" plugin's developers and ask them to fix
the "issue". It's like selling rocks as a tool to turn off TV sets.
Just throw a rock at the TV and it'll turn off! If it breaks your TV,
please don't complain to your TV manufacturer.
I also have intense emotional reaction to this kind of unloading. It
just feels rude to modify internal implementation details of software.
It's one thing to do it with code that only you yourself use, or to
apply this sort of dirty patching to a product you are intimately
familiar with, but it's quite another to distribute this crude tool as
a feature. It's disrespectful to the developers whose code is
brutalized, and it causes extra strain on them due to bug reports by
the affected users.
Messages sorted by: