Zsh Mailing List Archive Messages sorted by: Reverse Date, Date, Thread, Author

Re: [PATCH 1/3] src: fix build warnings

X-seq: zsh-workers 47795
From: Daniel Shahaf <d.s@xxxxxxxxxxxxxxxxxx>
To: Felipe Contreras <felipe.contreras@xxxxxxxxx>
Cc: Mikael Magnusson <mikachu@xxxxxxxxx>, Zsh hackers list <zsh-workers@xxxxxxx>
Subject: Re: [PATCH 1/3] src: fix build warnings
Date: Mon, 4 Jan 2021 05:14:48 +0000
Archived-at: <https://zsh.org/workers/47795>
Archived-at: <http://www.zsh.org/sympa/arcsearch_id/zsh-workers/2021-01/20210104051448.083bb483%40tarpaulin.shahaf.local2>
In-reply-to: <CAMP44s05KAVSWP90NeZ5DnUOSTkKF4eEmFJqHCDxn6ERuG5BjQ@mail.gmail.com>
List-id: <zsh-workers.zsh.org>
References: <20201231054131.682544-1-felipe.contreras@gmail.com> <20201231054131.682544-2-felipe.contreras@gmail.com> <8591b9d9-f2f0-4045-b8e2-d1b759a360c0@www.fastmail.com> <CAHYJk3QvTvjtvQFRfbn+r9S3f4mBC6Pfef6exG4HSE5BrU9EHg@mail.gmail.com> <CAMP44s05KAVSWP90NeZ5DnUOSTkKF4eEmFJqHCDxn6ERuG5BjQ@mail.gmail.com>

Felipe Contreras wrote on Sat, 02 Jan 2021 12:30 -0600:
> The best fix is to allocate one byte, especially if it's going to be
> freed later on.

Yes, please revise the patch to allocate byte(s) from the heap as
needed.  (See comments at the top of mem.c, and, for instance,
dupstring() v. ztrdup().)

Follow-Ups:
- Re: [PATCH 1/3] src: fix build warnings
  - From: Lawrence Velázquez

References:
- Re: [PATCH 1/3] src: fix build warnings
  - From: Daniel Shahaf
- Re: [PATCH 1/3] src: fix build warnings
  - From: Mikael Magnusson
- Re: [PATCH 1/3] src: fix build warnings
  - From: Felipe Contreras

Messages sorted by: Reverse Date, Date, Thread, Author