Zsh Mailing List Archive
Messages sorted by: Reverse Date, Date, Thread, Author

Re: [PATCH] Fix zstyle option completion



Lawrence Velázquez wrote on Sat, Mar 27, 2021 at 16:08:12 -0400:
> On Mon, Dec 14, 2020, at 4:55 AM, dana wrote:
> > On 13 Dec 2020, at 11:31, Daniel Shahaf <d.s@xxxxxxxxxxxxxxxxxx> wrote:
> > > Could you clarify the precise LBUFFER/RBUFFER values that "won't
> > > complete"?
> > 
> > For example, when i do:
> > 
> >   # LBUFFER='zstyle -'
> >   # RBUFFER=' foo bar'
> >   % zstyle -<TAB> foo bar
> > 
> > ... it tries (unsuccessfully) to complete argument-1 instead of showing me
> > options.
> > 
> > On 13 Dec 2020, at 11:31, Daniel Shahaf <d.s@xxxxxxxxxxxxxxxxxx> wrote:
> > > As written, I think the patch will cause «zstyle -g foo bar baz <TAB>»
> > > to offer completions, whereas currently it correctly completes nothing.
> > 
> > I don't think it should. All the options are exclusive with each other, so
> > that takes care of that already, and the -A '-*' should handle cases like
> > `zstyle foo bar <TAB>`. It gives me 'no more arguments' when i test your
> > example with my change. But i might not fully understand what you mean
> 
> Anything further on this?

Pushed.  Also fixed the X-Seq's in ChangeLog while I was at it.  Thank
you both!




Messages sorted by: Reverse Date, Date, Thread, Author