Zsh Mailing List Archive
Messages sorted by: Reverse Date, Date, Thread, Author

Re: [PATCH] Add -L to add-(zsh|zle)-hook[-widget] completion

On 21 Apr 2021, at 00:36, Daniel Shahaf <d.s@xxxxxxxxxxxxxxxxxx> wrote:
>> From 8b0221296db36c4d55d1b99577886f72afd76d3b Mon Sep 17 00:00:00 2001
>> From: Marlon Richert <marlon.richert@xxxxxxxxx>
>> Date: Mon, 19 Apr 2021 20:24:36 +0300
>> Subject: [PATCH] Add -L to add-(zsh|zle)-hook[-widget] completion
> The patch has already been merged, but still:
> Symbols names should be able to be grepped for, so please don't hide
> them behind glob patterns.

Ah, you mean in the commit message? Fair enough. I was just trying to keep the first line of the commit message to 50 characters or less, in line with [Git’s recommendations](https://book.git-scm.com/docs/git-commit#_discussion). But point taken; I will spell it out next time, if not in the first line, then at least in an additional line.

In any case, Oliver did add the exact function names to Changelog:

diff --git a/ChangeLog b/ChangeLog
index 7cf9ec4e5..079b92d32 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,5 +1,9 @@
 2021-04-19  Oliver Kiddle  <opk@xxxxxxx>
+   * Marlon Richert: 48621: Completion/Zsh/Function/_add-zsh-hook,
+   Completion/Zsh/Function/_add-zle-hook-widget: Add -L to
+   add-(zsh|zle)-hook[-widget] completion
        * André Kugland: github/zsh-completions #792:
        Completion/Unix/Command/_opustools: new opus-tools completion

Messages sorted by: Reverse Date, Date, Thread, Author