Re: Let run-help filter cmd_args before calling run-help-<command> (was Re: [RFC][PATCH] Try calling command with help flags in run-help)

[Bart Schaefer <schaefer@xxxxxxxxxxxxxxxx>]

This one appears clean.  Thanks.

On Thu, Jul 29, 2021 at 5:11 AM Marlon Richert <marlon.richert@xxxxxxxxx> wrote:
>
> On Wed, Jul 28, 2021 at 8:58 PM Bart Schaefer <schaefer@xxxxxxxxxxxxxxxx> wrote:
> >
> > On Sun, Jul 18, 2021 at 11:46 AM Lawrence Velázquez <larryv@xxxxxxx> wrote:
> > >
> > > On Sun, Jun 20, 2021, at 2:01 PM, Lawrence Velázquez wrote:
> > > > On Sat, Jun 5, 2021, at 3:15 PM, Marlon Richert wrote:
> > > > > New patch here with test cases, plus a rewrite of run-help-git. All the
> > > > > tests succeed for both the new and old versions of the run-help-*
> > > > > functions (except for the old run-help-git, because the new
> > > > > run-help-git uses `git help` instead of `man`).
> > > > >
> > > > > Attachments:
> > > > > * 0001-Let-run-help-filter-cmd_args-before-calling-run-help.txt
> > > >
> > > > bump
> > >
> > > bump bump
> >
> > Nothing obviously wrong with the code patch, but one of the test cases
> > fails for me:
> >
> > --- /tmp/zsh.ztst.50384/ztst.out    2021-07-28 10:56:06.301935368 -0700
> > +++ /tmp/zsh.ztst.50384/ztst.tout    2021-07-28 10:56:06.301935368 -0700
> > @@ -1,2 +0,0 @@
> > -git is WHENCE:{git}
> > -GIT:{'help' 'git'}
> > Test ./Z03run-help.ztst failed: output differs from expected as shown above for:
> >   BUFFER_STACK='git --exec-path'
> > Was testing: git with option
> > ./Z03run-help.ztst: test failed.
>
> Looks like I somehow managed to omit some lines from the tests in the
> patch. Here's a new patch, differing only in the `run-help git` tests: