Zsh Mailing List Archive
Messages sorted by: Reverse Date, Date, Thread, Author

Re: [PATCH] Increase $COLUMNS when generating long option completions



On Thu, Aug 5, 2021 at 9:24 AM Bart Schaefer <schaefer@xxxxxxxxxxxxxxxx> wrote:
>
> On Wed, Aug 4, 2021 at 11:20 PM Marlon Richert <marlon.richert@xxxxxxxxx> wrote:
> >
> > I don't think this all changes anything about the patch, though?
>
> On Tue, Aug 3, 2021 at 8:48 PM Bart Schaefer <schaefer@xxxxxxxxxxxxxxxx> wrote:
> >
> > The next question would be, is _arguments the only place this is
> > useful?  Or would it be better  if _call_program always did so? E.g.
> >   local -x COLUMNS

Sorry, I missed this. I don't know if it makes sense to always set
COLUMNS in _call_program, because it is not always called to produce
visual output. On the other hand, if you think it won't hurt, then
yes, that might be a better option.

> If the answer to that is to leave it in _arguments, then I think
> COLUMNS=$COLUMNS is preferable to COLUMNS=999

I made it 999, rather than $COLUMNS, because the output is cached and
terminal emulators can be resized.




Messages sorted by: Reverse Date, Date, Thread, Author