Zsh Mailing List Archive Messages sorted by: Reverse Date, Date, Thread, Author

Re: [PATCH] Remove redundancies from `git` completion

X-seq: zsh-workers 49347
From: Daniel Shahaf <d.s@xxxxxxxxxxxxxxxxxx>
To: Marlon Richert <marlon.richert@xxxxxxxxx>
Cc: Zsh hackers list <zsh-workers@xxxxxxx>
Subject: Re: [PATCH] Remove redundancies from `git` completion
Date: Wed, 1 Sep 2021 13:56:46 +0000
Archived-at: <https://zsh.org/workers/49347>
In-reply-to: <CAHLkEDt9=VdVFqvvwUfXb8HBO_uxZAnaS7f_gtBTSHy_XLMWsg@mail.gmail.com>
List-id: <zsh-workers.zsh.org>
References: <CAHLkEDt9=VdVFqvvwUfXb8HBO_uxZAnaS7f_gtBTSHy_XLMWsg@mail.gmail.com>

Marlon Richert wrote on Mon, Aug 30, 2021 at 14:17:17 +0300:
> In _git-show, remove calls to __git_commits and __git_tags.
>   Rationale: 'commits' and 'tags' are already added by __git_trees.
>   Adding them twice makes `zstyle ... tag-order` give unexpected
>   results.
> 

Complete example, please?

> In __git_recent_commits, remove the line that adds 'heads'.
>   Rationale: The completion for most subcommands already adds
>   'heads-local' and 'heads-remote'. Adding an additional 'heads' inside
>   __git_recent_commits results in heads being listed twice in two
>   separate groups.

Complete example, please?  Also, what about those subcommands that
*don't* already add heads-local and heads-remote?

Follow-Ups:
- Re: [PATCH] Remove redundancies from `git` completion
  - From: Marlon Richert

References:
- [PATCH] Remove redundancies from `git` completion
  - From: Marlon Richert

Messages sorted by: Reverse Date, Date, Thread, Author