Re: PATCH: pattern incremental search

[Lawrence Velázquez <larryv@xxxxxxx>]

On Mon, Feb 28, 2022, at 11:54 AM, Madhu wrote:
> This doesn't fix the segfault: which just gets postponed.  Besides
> this breaks incremental-pattern-search, which just stops working and
> doesn't match anything in the history. Also, the segfault only occurs
> when zsh is built without multibyte.
>
> To hit the segfault, in a --disable-multibyte build
> $ zsh -f
> $ bindkey ^R history-incremental-pattern-search-backward
> C-r .
>
> Please consider the attached patch which 1) reverts the above fix, and
> 2) modifies the non-multibyte version of igetmatch to match the
> multibyte version at some points. (Disclaimer. this is submitted with
> no understanding of what the code does :)
>
>
> Attachments:
> * glob.c-fix-segfault-on-non-multibyte-history-inc.patch

Was this fully obviated by workers/49870 (git 3bf95b9)?

-- 
vq