Zsh Mailing List Archive Messages sorted by: Reverse Date, Date, Thread, Author

Re: [PATCH][RFC] Improve completion of Gradle tasks

X-seq: zsh-workers 50182
From: Marlon Richert <marlon.richert@xxxxxxxxx>
To: dana <dana@xxxxxxx>
Cc: Bart Schaefer <schaefer@xxxxxxxxxxxxxxxx>, Zsh hackers list <zsh-workers@xxxxxxx>
Subject: Re: [PATCH][RFC] Improve completion of Gradle tasks
Date: Sat, 7 May 2022 09:03:40 +0300
Archived-at: <https://zsh.org/workers/50182>
In-reply-to: <e288b6d0-c76e-482d-92e2-630b971ff49b@www.fastmail.com>
List-id: <zsh-workers.zsh.org>
References: <e288b6d0-c76e-482d-92e2-630b971ff49b@www.fastmail.com>

On 7 May 2022, at 07:24, dana <dana@xxxxxxx> wrote:

On Fri 6 May 2022, at 21:57, Bart Schaefer wrote:
Any objections to this sneaking into 5.9, despite .3-test already spun?

I don't know anything about Gradle, so i'm not sure if the way it handles
task completion is desirable.

The old task completion logic was too strict: There were many real-world task names that it did not complete. Also, the logic was actually incorrect: There were some forms of names that it did not allow, but which are explicitly allowed in Gradle’s spec.

But i didn't see anything obviously wrong
with the patch, and it's not a critical component, so i don't object in
principle

Great! :)

I did note these pre-existing issues which might be fixed in a future
revision:

Yes, I noticed these, too. I will have a look at fixings them sometime in a future patch.

References:
- Re: [PATCH][RFC] Improve completion of Gradle tasks
  - From: dana

Messages sorted by: Reverse Date, Date, Thread, Author