Zsh Mailing List Archive
Messages sorted by:
Reverse Date,
Date,
Thread,
Author
Re: [PATCH] prompt: support generic non-visible regions
- X-seq: zsh-workers 50464
- From: Felipe Contreras <felipe.contreras@xxxxxxxxx>
- To: Roman Perepelitsa <roman.perepelitsa@xxxxxxxxx>
- Cc: zsh-workers@xxxxxxx, Oliver Kiddle <opk@xxxxxxx>, dana <dana@xxxxxxx>
- Subject: Re: [PATCH] prompt: support generic non-visible regions
- Date: Thu, 11 Aug 2022 14:23:50 -0500
- Archived-at: <https://zsh.org/workers/50464>
- In-reply-to: <CAN=4vMqwjOtABPgDsXioP7NBxw=O3RRbDt7ZB7CLHtTR-omvPw@mail.gmail.com>
- List-id: <zsh-workers.zsh.org>
- References: <20220810115120.182853-1-felipe.contreras@gmail.com> <CAN=4vMqHNZJ7BvCCNbD7-0nPr1CbN1ecHQVxSsaZQ1Ao13__jg@mail.gmail.com> <CAN=4vMqwjOtABPgDsXioP7NBxw=O3RRbDt7ZB7CLHtTR-omvPw@mail.gmail.com>
On Thu, Aug 11, 2022 at 12:24 PM Roman Perepelitsa
<roman.perepelitsa@xxxxxxxxx> wrote:
>
> On Thu, Aug 11, 2022 at 4:37 PM Roman Perepelitsa
> <roman.perepelitsa@xxxxxxxxx> wrote:
> >
> > I like this patch [...]
>
> I should've said that I like the idea behind it. The patch implements
> one part of it. To complete the implementation percent expansion needs
> to output \001 and \002.
That's easy. The current code in prompt.c uses Inpar and Outpar, which
are 0x88 and 0x8A respectively. If instead we do:
#define invis_start ((char) 0x01)
#define invis_end ((char) 0x02)
And replace Inpar/Outpar with invis_start/invis_end the code should
behave identically (since those characters are removed).
Then in promptexpand() we simply not remove them.
I'm not sure if leaking these characters is what we want though.
--
Felipe Contreras
Messages sorted by:
Reverse Date,
Date,
Thread,
Author