Re: [PATCH v2] prompt: support generic non-visible regions

[Bart Schaefer <schaefer@xxxxxxxxxxxxxxxx>]

On Sun, Aug 14, 2022 at 3:47 PM Felipe Contreras
<felipe.contreras@xxxxxxxxx> wrote:
>
> > How does one embed a literal ctrl-A or ctrl-B in the prompt?
>
> What would that achieve?

Nothing specific, but one can embed any other literal character, so
why not those?

> > I haven't found any readline documentation that explains the use of
> > "start of header" or "start of text".
>
> It's in the code:

Ah, so "start of header/text" is your phrasing, not theirs.

> > I'm also leaning to the opinion that \001 and \002 should only be
> > recognized when PROMPT_PERCENT is unset.
>
> That would defeat the primary purpose of the patch, which is to be
> able to write prompt helper functions which work in multiple shells.

In that case I think the patch is incomplete, because it's not keeping
track of bv->dontcount and will be confused if both \001 and %} are
used (or %{ and \002).  See lines 602 through 628 of Src/prompt.c
(line numbers as of commit c5a891a2).