Zsh Mailing List Archive Messages sorted by: Reverse Date, Date, Thread, Author

Re: [PATCH] Introduce ZCALC_HISTFILE

X-seq: zsh-workers 50617
From: Lawrence Velázquez <larryv@xxxxxxx>
To: "Julian Prein" <druckdev@xxxxxxxxxxxxxx>
Cc: zsh-workers@xxxxxxx
Subject: Re: [PATCH] Introduce ZCALC_HISTFILE
Date: Fri, 09 Sep 2022 20:49:59 -0400
Archived-at: <https://zsh.org/workers/50617>
Feedback-id: iaa214773:Fastmail
In-reply-to: <cu_uqi1WBhr8VVDu-7ICNl25mUJPtLbGc7AeyyrQRNXdW59w6rj64ms1NZ4Lx5Ixia9asyaEC2iOvEavfAqNGBIBtIYks7M9P-FVXqnueO4=@protonmail.com>
List-id: <zsh-workers.zsh.org>
References: <cu_uqi1WBhr8VVDu-7ICNl25mUJPtLbGc7AeyyrQRNXdW59w6rj64ms1NZ4Lx5Ixia9asyaEC2iOvEavfAqNGBIBtIYks7M9P-FVXqnueO4=@protonmail.com>

Hi Julian,

Thanks for the submission!  I don't have a particular opinion on
this proposal, but...

On Fri, Sep 9, 2022, at 7:27 PM, Julian Prein wrote:
> +the file tt($ZCALC_HISTFILE).  If tt($ZCALC_HISTFILE) is unset,
> +tt($ZDOTDIR/.zcalc_history) is used instead.

This doesn't align with the actual code.

>  # We use our own history file with an automatic pop on exit.
> -history -ap "${ZDOTDIR:-$HOME}/.zcalc_history"
> +history -ap "${ZCALC_HISTFILE:-${ZDOTDIR:-$HOME}/.zcalc_history}"

Consider something along the lines of:

	Full command line editing, including the history of previous
	calculations, is available; the history is saved in the
	file specified by $ZCALC_HISTFILE, $ZDOTDIR/.zcalc_history
	(if $ZCALC_HISTFILE is unset or empty), or $HOME/.zcalc_history
	(if both $ZCALC_HISTFILE and $ZDOTDIR are unset or empty).

-- 
vq

Follow-Ups:
- Re: [PATCH] Introduce ZCALC_HISTFILE
  - From: Julian Prein

References:
- [PATCH] Introduce ZCALC_HISTFILE
  - From: Julian Prein

Messages sorted by: Reverse Date, Date, Thread, Author