Zsh Mailing List Archive
Messages sorted by: Reverse Date, Date, Thread, Author

Re: [PATCH] out of memory error after "edit-command-line"



On Tue, Oct 18, 2022 at 8:08 AM Jun. T <takimoto-j@xxxxxxxxxxxxxxxxx> wrote:
>
>   dosetopt() has the extra code only when setting MONITOR to ON.
> so again just opts[MONITOR]=on is enough in doshfunc().... Is this correct?

Hm, the shell having acquired the process group when MONITOR turned ON
... I don't know of any way to relinquish it again.  So either this
has to change in dosetopt() as well if it's even possible, or
doshfunc() is OK.

> The patch below forces 'bindkey -e/-v' to set the option EMACS or VI.
> Is this OK?

The only possible reason I can think of why this would not be OK is
that it will change the output of "setopt" when its "form is chosen so
as to minimize the differences from the default options for the
current emulation".  That seems a pretty insignificant issue, but
might warrant mention in NEWS or even in the incompatibilities section
of README.

> I _hope_ there is no other option that require extra code in doshfunc().

The only ones I was worried about seem to be in the set of those that
can't be changed after startup, or that can't change back again
(PRIVILEGED, RESTRICTED).




Messages sorted by: Reverse Date, Date, Thread, Author