Zsh Mailing List Archive Messages sorted by: Reverse Date, Date, Thread, Author

Re: [PATCH] zsh/random module

X-seq: zsh-workers 50859
From: Bart Schaefer <schaefer@xxxxxxxxxxxxxxxx>
To: Clinton Bunch <cdb_zsh@xxxxxxxxxxx>
Cc: "zsh-workers@xxxxxxx" <zsh-workers@xxxxxxx>
Subject: Re: [PATCH] zsh/random module
Date: Thu, 3 Nov 2022 10:50:50 -0700
Archived-at: <https://zsh.org/workers/50859>
In-reply-to: <741b77be-b679-76cc-f8ec-49c9d89323c1@zentaur.org>
List-id: <zsh-workers.zsh.org>
References: <741b77be-b679-76cc-f8ec-49c9d89323c1@zentaur.org>

On Wed, Nov 2, 2022 at 10:14 AM Clinton Bunch <cdb_zsh@xxxxxxxxxxx> wrote:
>
> I'd appreciate if someone would test it on a few other platforms and try
> to break it.  I tried everything I could think of, but...

Seems to work on MacOS Catalina.  If you add a Test/ file for "make
check" we'll get more coverage.

Documentation suggestions:

    -s SCALAR
          Save the random data in SCALAR instead of printing it. Only
          useful in string mode or when LENGTH is 1.

Actually say that this is an error for -i with length > 1, rather than
just "Only useful when".  Avoids use of the undefined term "string
mode" and better describes the behavior.  I wonder if using both -i
and -s should default length to 1 rather than 8 ... otherwise you
should state that you can't use them together without also using -l.

I'd have put -L before -U but I suppose you expect -U to be used more
frequently.

References:
- [PATCH] zsh/random module
  - From: Clinton Bunch

Messages sorted by: Reverse Date, Date, Thread, Author