Zsh Mailing List Archive Messages sorted by: Reverse Date, Date, Thread, Author

Re: [PATCH] Re: Bug: Callback to widget set with `zle -Fw <widget>` shouldn't change $LASTWIDGET

X-seq: zsh-workers 51315
From: Bart Schaefer <schaefer@xxxxxxxxxxxxxxxx>
To: Peter Stephenson <p.w.stephenson@xxxxxxxxxxxx>
Cc: Zsh hackers list <zsh-workers@xxxxxxx>
Subject: Re: [PATCH] Re: Bug: Callback to widget set with `zle -Fw <widget>` shouldn't change $LASTWIDGET
Date: Tue, 17 Jan 2023 10:00:43 -0800
Archived-at: <https://zsh.org/workers/51315>
In-reply-to: <422608219.9324398.1673947338127@mail.virginmedia.com>
List-id: <zsh-workers.zsh.org>
References: <CAHLkEDuuosi7udHsQ9uaBRcv5poEUU_i1iSRGgEXFbtBkzHQOQ@mail.gmail.com> <CAH+w=7Y4jT5kNNSkCXZMcFg7kzTew3LDfLgq8zPkr30D5=QSsA@mail.gmail.com> <422608219.9324398.1673947338127@mail.virginmedia.com>

On Tue, Jan 17, 2023 at 1:23 AM Peter Stephenson
<p.w.stephenson@xxxxxxxxxxxx> wrote:
>
> > On 17/01/2023 00:01 Bart Schaefer <schaefer@xxxxxxxxxxxxxxxx> wrote:
> > Is this good enough, or is there a need to consider that the handler
> > might delete the previous last widget?
>
> I think just keeping
> the old name and letting the user deal with it further is good enough.

My concern is that the Thingy pointer becomes invalid.  If that won't
happen, nothing further is needed here.  If that COULD happen, then
the implementation of $LASTWIDGET needs to start storing the name
rather than the Thingy.

Follow-Ups:
- Re: [PATCH] Re: Bug: Callback to widget set with `zle -Fw <widget>` shouldn't change $LASTWIDGET
  - From: dana

References:
- [PATCH] Re: Bug: Callback to widget set with `zle -Fw <widget>` shouldn't change $LASTWIDGET
  - From: Bart Schaefer
- Re: [PATCH] Re: Bug: Callback to widget set with `zle -Fw <widget>` shouldn't change $LASTWIDGET
  - From: Peter Stephenson

Messages sorted by: Reverse Date, Date, Thread, Author