Zsh Mailing List Archive Messages sorted by: Reverse Date, Date, Thread, Author

Re: PATCH: Possible copy paste error?

X-seq: zsh-workers 51492
From: Peter Stephenson <p.w.stephenson@xxxxxxxxxxxx>
To: zsh-workers@xxxxxxx
Subject: Re: PATCH: Possible copy paste error?
Date: Tue, 28 Feb 2023 13:49:58 +0000 (GMT)
Archived-at: <https://zsh.org/workers/51492>
Importance: Normal
In-reply-to: <20230228133723.2945-1-mikachu@gmail.com>
List-id: <zsh-workers.zsh.org>
References: <20230228133723.2945-1-mikachu@gmail.com>

> On 28/02/2023 13:37 Mikael Magnusson <mikachu@xxxxxxxxx> wrote:
> Coverity noticed that this first branch of the if statement has "meta"
> added to all the variable names except this zlecs at the end, should it?
> (I'm asking the same question)

It should be all or nothing, yes.  Either the metafied version is valid
or it isn't and if it is the non-metafied version isn't currently useful.
(You might get away with it depending on what changed since conversion.)

pws

References:
- PATCH: Possible copy paste error?
  - From: Mikael Magnusson

Messages sorted by: Reverse Date, Date, Thread, Author