Re: Patch 1/3: Fix prefix insertion logic

[Bart Schaefer <schaefer@xxxxxxxxxxxxxxxx>]

On Mon, May 1, 2023 at 2:10 PM Aaron Schrab <aaron@xxxxxxxxxx> wrote:
>
> I certainly don't find "Fix prefix insertion logic" to be a very helpful
> commit message. It might be a decent subject, but I'd expect the full
> message to give at least *some* idea of what the problem is.

Yes, if this connects back to an earlier thread ("Why is an 'x'
appended ..." maybe?) then some reference to that should be made.

> The second patch in the series had a subject that I'd consider slightly
> more useful ("Make dynamic dir completion easier to implement"), but I'd
> generally expect the description to give some idea of how it makes
> implementation easier.

Also, easier for whom?  If the end user, I'd expect some sort of doc
change, or at least a reference to what's currently difficult.

> The final patch of the series does appear to have a decent message,
> although I haven't attempted to check how it lines up with the actual
> patch.

This one looks OK, the included test cases appear to exemplify the issue.