Zsh Mailing List Archive Messages sorted by: Reverse Date, Date, Thread, Author

Re: [PATCH] Let _approximate work w/ possible compadd function

X-seq: zsh-workers 51805
From: Bart Schaefer <schaefer@xxxxxxxxxxxxxxxx>
To: Marlon Richert <marlon.richert@xxxxxxxxx>
Cc: zsh-workers@xxxxxxx
Subject: Re: [PATCH] Let _approximate work w/ possible compadd function
Date: Sat, 27 May 2023 09:11:08 -0700
Archived-at: <https://zsh.org/workers/51805>
In-reply-to: <20230527131253.33840-1-marlon.richert@gmail.com>
List-id: <zsh-workers.zsh.org>
References: <20230527131253.33840-1-marlon.richert@gmail.com>

On Sat, May 27, 2023 at 6:13 AM Marlon Richert <marlon.richert@xxxxxxxxx> wrote:
>
> Before this patch, if compadd had been overridden by a function of the
> same name, _approximate would not do corrections.

This is what _shadow was added for.  I don't remember why I didn't
apply it to _approximate when I did so for _complete_help, but
possibly it's because those usages actually conflict, i.e., when
running the help function you don't want approximate to bypass the
override?  Will have to think about this a bit when I have more time.

The primary difference from your patch is that _shadow will handle
recursive calls to the function in which it is used.

Follow-Ups:
- Re: [PATCH] Let _approximate work w/ possible compadd function
  - From: Marlon Richert

References:
- [PATCH] Let _approximate work w/ possible compadd function
  - From: Marlon Richert

Messages sorted by: Reverse Date, Date, Thread, Author