Zsh Mailing List Archive
Messages sorted by: Reverse Date, Date, Thread, Author

Re: [PATCH] Add option like tcsh's dextract



On 8/9/23, Tim Eliseo <tre-zsh@xxxxxxxxxxxxxx> wrote:
> On 2023-08-09 06:16:54, Mikael Magnusson wrote:
>>
>> Every time I've asked for more details you ignored me, which as I
>> pointed out earlier is not a good approach. I thought I very clearly
>> asked you in my first mail why just cd + autopushd was not enough, and
>> then you wouldn't even reply to my second request to answer my
>> question which surely put others off as well.
>>
>> To summarize, when you send a mail with a patch, explain the patch and
>> why it's needed in the mail; if someone asks for clarifications or
>> seems to misunderstand you, rather than assume that they can't read,
>> assume that you were unclear, it is the safer assumption.
>>
> I’ll agree that we had a misunderstanding, and will keep this in mind
> for the future.
>
> Do you have any remaining questions or concerns that prevent this patch
> from being merged?

The manpage entry says:
  This option makes tt(pushd) using `tt(PLUS())' or `tt(-)' behave
like tt(cd) with tt(AUTO_PUSHD) set.

This is true as I understand it, but it somewhat implies that pushd
without +/- acts differently from cd, so perhaps it should just say
"This option makes pushd behave like cd with AUTO_PUSHD set.", which
is also true but harder to misinterpret. (I wouldn't oppose keeping it
as it is, it's just something that tripped me up while reading it.)

Another thought I had was that perhaps with this option existing, the
behavior between cd and pushd need not be different at all anymore,
but maybe someone prefers being able to extract with cd and roll with
pushd, so probably not worth messing with that. It would also be
unclear which way the default should be in that case...

-- 
Mikael Magnusson




Messages sorted by: Reverse Date, Date, Thread, Author