Zsh Mailing List Archive Messages sorted by: Reverse Date, Date, Thread, Author

Re: [PATCH] Initialization of main keymap [redux]

X-seq: zsh-workers 52209
From: Mikael Magnusson <mikachu@xxxxxxxxx>
To: Bart Schaefer <schaefer@xxxxxxxxxxxxxxxx>
Cc: Zsh hackers list <zsh-workers@xxxxxxx>
Subject: Re: [PATCH] Initialization of main keymap [redux]
Date: Sat, 7 Oct 2023 20:25:36 +0200
Archived-at: <https://zsh.org/workers/52209>
In-reply-to: <CAH+w=7Y0aSdp_27josJzWXOwb_eaqajragSueE3TMK8c252BeQ@mail.gmail.com>
List-id: <zsh-workers.zsh.org>
References: <CAH+w=7Y0aSdp_27josJzWXOwb_eaqajragSueE3TMK8c252BeQ@mail.gmail.com>

On 10/23/22, Bart Schaefer <schaefer@xxxxxxxxxxxxxxxx> wrote:
> Here's an update to my patch from workers/50559.  The patch herein
> correctly compares only the string to the right of the rightmost "/"
> and also always prefers $VISUAL to $EDITOR.
>
> Daniel proposed alternately in workers/50569 that we discard this test
> entirely and always default to the emacs keymap.  I don't feel
> strongly about it but as it's currently broken for many cases of
> setting those variables to a full path, we should pick one or the
> other.

I noticed we still haven't picked one of these. I would personally
prefer the patch that removes the check (Daniel's), but either is fine
with me. Have we heard from anyone who depends on it selecting vi
bindings for them?

-- 
Mikael Magnusson

Follow-Ups:
- Re: [PATCH] Initialization of main keymap [redux]
  - From: Bart Schaefer

Messages sorted by: Reverse Date, Date, Thread, Author