Zsh Mailing List Archive
Messages sorted by: Reverse Date, Date, Thread, Author

Re: PATCH: Improve quote handling in _ant completion



On Wed, Nov 29, 2023 at 11:56 AM Mikael Magnusson <mikachu@xxxxxxxxx> wrote:
>
> On 11/29/23, Bart Schaefer <schaefer@xxxxxxxxxxxxxxxx> wrote:
> > -                    print -n "'${default_target}:(Default target) ' "
> > +                    print -rn -- "${(qq):-${default_target}:(Default target) } "

A similar change needs to be applied a bit later, I think:

                 (*)
                     # Return target and description
-                    print -n "'$ln' "
+                    print -rn -- "${(qq):-$ln} "
                 ;;

If this seems OK I'll prepare a proper patch.

> >> Also I am proposing to shield 'find_targets' with '((
> >> $#functions[find_targets] )) ||' so that users can easily override the
> >> function.
>
> It should probably also be renamed to _ant_find_targets or something

Agreed.




Messages sorted by: Reverse Date, Date, Thread, Author