Re: [PATCH] C compatiblity fixes for the configure script (incompatible-pointer-types)

[Oliver Kiddle <opk@xxxxxxx>]

Bart Schaefer wrote:
> On Fri, Dec 8, 2023 at 12:58 PM Florian Weimer <fweimer@xxxxxxxxxx> wrote:
> >
> > Avoid incompatible pointer types in terminfo global variable checks.
>
> For the record, the incompatibility seems to be that ncurses now
> declares these as arrays of const pointer to const char.
>
> Curiously (incorrectly?) the Solaris 11.3 documentation available
> online shows them as only char*, not even char**.

Checking /usr/include/term.h on 11.4 and 10, it is:

extern  char    term_parm_err[], *term_err_strings[], *Def_term,
                *boolnames[], *boolcodes[], *boolfnames[],
                *numnames[], *numcodes[], *numfnames[],
                *strnames[], *strcodes[], *strfnames[];

The patch has no impact on a Solaris build.

And while I don't have a new enough compiler to verify the described
problem, I don't doubt it. I can't see adding a cast to the type it is
being assigned to causing problems so no objections from me.

Oliver