Zsh Mailing List Archive Messages sorted by: Reverse Date, Date, Thread, Author

Re: PATCH: Simplify resolve_nameref and setscope

X-seq: zsh-workers 53746
From: Bart Schaefer <schaefer@xxxxxxxxxxxxxxxx>
To: Philippe Altherr <philippe.altherr@xxxxxxxxx>
Cc: Zsh hackers list <zsh-workers@xxxxxxx>
Subject: Re: PATCH: Simplify resolve_nameref and setscope
Date: Sun, 8 Jun 2025 11:12:33 -0700
Archived-at: <https://zsh.org/workers/53746>
In-reply-to: <CAGdYchtw_fUP16UwRTnzMWRcA4XbSq4VzN_QawjRgeM0Pmqkqg@mail.gmail.com>
List-id: <zsh-workers.zsh.org>
References: <CAGdYchtw_fUP16UwRTnzMWRcA4XbSq4VzN_QawjRgeM0Pmqkqg@mail.gmail.com>

There are some mechanical problems with this patch:
- It omits a change on line 3132 of builtin.c (arguments to resolve_nameref).
- It uses a constant "false" which appears nowhere else in our sources.
- we have been following the practice of always declaring variables at
the start of a code block, even though it's not strictly necessary
with modern compilers.

Follow-Ups:
- Re: PATCH: Simplify resolve_nameref and setscope
  - From: Bart Schaefer

References:
- PATCH: Simplify resolve_nameref and setscope
  - From: Philippe Altherr

Messages sorted by: Reverse Date, Date, Thread, Author