Zsh Mailing List Archive Messages sorted by: Reverse Date, Date, Thread, Author

Re: follow up on workers/53803 patch for configuring wrap length and number of path elements shown for adam1 prompt

X-seq: zsh-workers 53913
From: dana <dana@xxxxxxx>
To: zsh@xxxxxxxxxxxx
Cc: zsh-workers@xxxxxxx
Subject: Re: follow up on workers/53803 patch for configuring wrap length and number of path elements shown for adam1 prompt
Date: Wed, 03 Sep 2025 04:15:09 -0500
Archived-at: <https://zsh.org/workers/53913>
Feedback-id: i9be146f9:Fastmail
In-reply-to: <175595497129.7.14194463039921048431.868319362@dandrake.org>
List-id: <zsh-workers.zsh.org>
References: <175595497129.7.14194463039921048431.868319362@dandrake.org>

On Sat 23 Aug 2025, at 08:16, zsh@xxxxxxxxxxxx wrote:
> Back in June, I submitted a patch, workers/53803: https://www.zsh.org/mla/workers/2025/msg00503.html
>
> Has that been merged or reviewed? It seems like a very small, safe enhancement, so I'm hoping it can get merged.

the message is formatted weirdly. the patch up for review is the top one
(27a613ca1..b4b91285b), right? if so i think it's ok. you should
probably update prompt_adam1_help() to mention the new parameters though

as to whether it should go into 5.10, idk. in principle it feels like we
should not be accepting enhancements to existing code, even minor ones,
during the testing phase

(would be nice to revisit release branches, e.g. workers/45441. not sure
what kind of buy-in that requires)

dana

References:
- follow up on workers/53803 patch for configuring wrap length and number of path elements shown for adam1 prompt
  - From: zsh

Messages sorted by: Reverse Date, Date, Thread, Author