Zsh Mailing List Archive Messages sorted by: Reverse Date, Date, Thread, Author

Re: [PATCH] compinit forks less

X-seq: zsh-workers 54438
From: dana <dana@xxxxxxx>
To: "Bart Schaefer" <schaefer@xxxxxxxxxxxxxxxx>
Cc: zsh-workers@xxxxxxx, "Charles Blake" <charlechaud@xxxxxxxxx>
Subject: Re: [PATCH] compinit forks less
Date: Fri, 01 May 2026 00:32:12 -0500
Archived-at: <https://zsh.org/workers/54438>
Feedback-id: i9be146f9:Fastmail
In-reply-to: <CAH+w=7aTJV-QcBtmWy=9_AmL=e21rKqn3n35qo6daXb+dk1N8w@mail.gmail.com>
List-id: <zsh-workers.zsh.org>
References: <CAKiz1a_X09-MpXhOwtD2H4tykBi9HTkLq52Xirc25WHXsmjn4w@mail.gmail.com> <da9600c7-48e6-44b7-91ba-57265e4e76b8@app.fastmail.com> <CAKiz1a9_6YTDSXX+Pkfqyn+hkgLMB-M4U3i07HnYkDj_wo1gEQ@mail.gmail.com> <CAH+w=7aTJV-QcBtmWy=9_AmL=e21rKqn3n35qo6daXb+dk1N8w@mail.gmail.com>

On Thu 30 Apr 2026, at 17:37, Bart Schaefer wrote:
> I'm not sure where you're coming up with "racy".  The same mechanism is used
> for this file as is used for =(...) substitutions.  If there's a problem
> here, there's a problem there.

there's a race between mktemp() checking whether the file exists and us
actually opening it

=( ) opens with O_EXCL so there's no security issue

${ } as sugar for >| clobbers, which is O_TRUNC, so no O_EXCL

i like your alternative. i didn't trace it (macos is garbage) but it
looks better. not sure about the fdtable question

dana

Follow-Ups:
- Re: [PATCH] compinit forks less
  - From: Charles Blake

References:
- [PATCH] compinit forks less
  - From: Charles Blake
- Re: [PATCH] compinit forks less
  - From: dana
- Re: [PATCH] compinit forks less
  - From: Charles Blake
- Re: [PATCH] compinit forks less
  - From: Bart Schaefer

Messages sorted by: Reverse Date, Date, Thread, Author