Zsh Mailing List Archive
Messages sorted by:
Reverse Date,
Date,
Thread,
Author
Re: PATCH: fix complist interactive mode overwriting buffer
- X-seq: zsh-workers 54610
- From: Bart Schaefer <schaefer@xxxxxxxxxxxxxxxx>
- To: Mikael Magnusson <mikachu@xxxxxxxxx>
- Cc: zsh-workers@xxxxxxx, Andrea Manenti <andrea.manenti@xxxxxxxxx>, Marlon Richert <marlon.richert@xxxxxxxxx>
- Subject: Re: PATCH: fix complist interactive mode overwriting buffer
- Date: Sun, 24 May 2026 10:31:45 -0700
- Arc-authentication-results: i=1; mx.google.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=eAr3u20NbZsLTQ292fPnZ3WX2+WPR1ntdUsJOWe4iVQ=; fh=CaZqFXNSOPd9vvavFV6LBbthTNYSQRNy6IiVp77uMP4=; b=WMe27tl6hzvH4MRrHO1aNFY191riSvWlOABvy+5vqRUNhNEZkfNUwOc0cET5Ig/eVR w3FD6NxyojfQmpaXi0I3ySiIZp8G7T+I+2VBYWaFLACOCZWnpI4JE5dW5Tqyy+mdo2Lk /IrG/TOLg1mfJHOU3jQ7OR10PO2hSqy4d1GCrvYM0+HJ/4ocOxRqDukj5eUcCyQDgGsq 8eM3YZUqKWmUDVl3gYTX7AQy+gLYQOZM359bv/Yzb6qqOUISyR3cFdzJuDuCPyxGLbZx hF8lW/Ms6IKoWWtxB8VBFDYZ0z7hdj8a9BNYUISt/06Ez0fzmeXMX7wIiIrWRBzCa2um h73g==; darn=zsh.org
- Arc-seal: i=1; a=rsa-sha256; t=1779643917; cv=none; d=google.com; s=arc-20240605; b=PvAxAVlZ9s0JSe6owbJ0dwYWJ7a+0R9bcfcTVjr59kfYEdPlpa81EJv7xpwtkYc187 lVf9E79yc/DemEJOaCydYL4n1RuaN+3yw7fkj1lv5vxdME5PRQ2gyaRAqbQl/MObCX71 Jm8egYhKTbTypBcGs9Dr1RIt5JO3WO5JVsX3cX2R1b6TZw+jRPjFtZr59q5Q6eqNiqz9 gTekw7/Bk4C/4LWp2j06bO2CpRK6lnHuFBL6Ue16XIvsFlVsXCUZzFh9Abv3A/IKU2Q7 tGZpnuRq/iUqOiQs6sewXSDTLyzyaTKSVwIMVerMgDQtCoHsCZKF+oNUkgkwaTCcISvV 6Rnw==
- Archived-at: <https://zsh.org/workers/54610>
- In-reply-to: <CAHYJk3RMxsN6uNHSDEfKX3W5JaEY5X1BQT6PJ=w8gaBGTCYO0Q@mail.gmail.com>
- List-id: <zsh-workers.zsh.org>
- References: <20260523063713.5100-1-mikachu@gmail.com> <CAHYJk3T4yZafOyDHKSkvm5enRXRaEmX72u3B8qTup44a6D8DAQ@mail.gmail.com> <CAH+w=7bj=YprzzC7xuEPg7zipKC2D48s3y6fYBh+gbsMBVFSLw@mail.gmail.com> <CAHYJk3RMxsN6uNHSDEfKX3W5JaEY5X1BQT6PJ=w8gaBGTCYO0Q@mail.gmail.com>
On Sun, May 24, 2026 at 7:45 AM Mikael Magnusson <mikachu@xxxxxxxxx> wrote:
>
> Dana was talking about completing quoted words and I realized I hadn't
> tried that at all, and it indeed doesn't work well very well.
I'll be really pleased if these two small changes are all that's
needed for that. Quoted word completion has been a thorn for a long
time. One of the issues (which I'm not sure this addresses) is that,
within some completer functions and perhaps also some internal
comparisons, get_comp_string() [?] has normalized the quoting so
(obviously invented example) the completion for {{'one two}} (unclosed
single quote) ends up testing {{one\ two}} vs. {{'one two'}} or
something like that.
> This is probably becoming a pain to try to apply manually, so I'll
> attach the combined patch for anyone looking to try it out, although
> at this point maybe I should just push?
I'm inclined toward the "just push".
Messages sorted by:
Reverse Date,
Date,
Thread,
Author