Zsh Mailing List Archive
Messages sorted by:
Reverse Date,
Date,
Thread,
Author
Re: PATCH: overflow check in isreallycom
- X-seq: zsh-workers 54616
- From: Mikael Magnusson <mikachu@xxxxxxxxx>
- To: Bart Schaefer <schaefer@xxxxxxxxxxxxxxxx>
- Cc: zsh-workers@xxxxxxx
- Subject: Re: PATCH: overflow check in isreallycom
- Date: Tue, 26 May 2026 01:51:29 +0200
- Arc-authentication-results: i=1; mx.google.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=J6n/RD8kc+FmbTJpwjUCxHAkHNx8ErD50UELwKS8AiU=; fh=QgfxxE0gysBJ7evxa0WZY5Olv+ibLYueRkqhtBdu00I=; b=iqBPxbOQdcfGTQTukralFVm9gGtNeaGICjpaPrJihxKyPDLSjJm4teeWZYiGxLbUnJ vXIjcd8WtPak/Q45vNZFTV/XBLV4WTdH73M9Paz1vMViHPJfc0iir69D73KMrx+/Bgu+ kFSK1GA2wofYHlampQb68K15BPfX9+KDjhqTQXZQrJlE+9WnnqeXtxxFrlfG8kxsOWAM w3GLol93PcYOevDJfR5QRxw3TIb7yKXMwo75d7Y2So4jPaP5ErAOCurq/zCSfkPaiphA osQDqq6dO4Vi6p7upp04lB/6Wyu1oBnNZ/1NRe36nmzAGoJ7ZX2pJNYegSlCvmT8wkBF qq6g==; darn=zsh.org
- Arc-seal: i=1; a=rsa-sha256; t=1779753103; cv=none; d=google.com; s=arc-20240605; b=T4NfXo6xQaMCU6N2WUGIb0tnAn0AciiWJhhTOwbf5sAdEqWlhvMjExpkozxKeqlq5n rj4SUeITmCZFvSKBFS0OWE3Ii5j1N1s/RP2wbuRJEqRTBBudk3l5VJfCqgfxXJ9CrzIk NG8w6wul9mF6K/Q7SILmm4XlDvihqRj0WmXKz7iyEzP+/eSFxI+YP1tmoyfJUJIIfFs4 dZTFq0sGs5Syz4QLBIwjg616NYjPqEkKyBzKX5RiRZ04NdDhqe6+0Ku4SYqMSk0v6nnp Fsizp+UsKDwfBEiF4JncKoRpBfmnFLRhv+ZIkAWmxtjLnn3Z4nv0VJl7HnxG1u0uQj6v YDTg==
- Archived-at: <https://zsh.org/workers/54616>
- In-reply-to: <CAH+w=7brW1QyO15RF1fSMjfhMQQppeuXXEXHqXamCgwdB7VR6Q@mail.gmail.com>
- List-id: <zsh-workers.zsh.org>
- References: <20260523063702.5005-1-mikachu@gmail.com> <CAH+w=7brW1QyO15RF1fSMjfhMQQppeuXXEXHqXamCgwdB7VR6Q@mail.gmail.com>
Ack, I know I caught a situation exactly like this in another change.
Thanks for spotting it. It's probably a good idea to add -Wall to my
CFLAGS. :)
On Mon, May 25, 2026 at 11:48 PM Bart Schaefer
<schaefer@xxxxxxxxxxxxxxxx> wrote:
>
> There's an ambiguous if/else chain in exec.c:
>
> exec.c:1012:5: warning: add explicit braces to avoid dangling else
> [-Wdangling-else]
> 1012 | else if (!cn->u.name)
> | ^
> 1 warning generated.
--
Mikael Magnusson
Messages sorted by:
Reverse Date,
Date,
Thread,
Author