Zsh Mailing List Archive
Messages sorted by:
Re: Zle patch - termok change
- X-seq: zsh-workers 2971
- From: "Bart Schaefer" <schaefer@xxxxxxxxxxxxxxxxxxxxxxx>
- To: gwing@xxxxxxxxxxxxxxx, zsh-workers@xxxxxxxxxxxxxxx (zsh-workers)
- Subject: Re: Zle patch - termok change
- Date: Fri, 7 Mar 1997 01:43:59 -0800
- In-reply-to: gwing@xxxxxxxxxxxxxxx "Zle patch - termok change" (Mar 7, 6:23pm)
- References: <19970307072357.19867.qmail@xxxxxxxxxxxxxxx>
- Reply-to: schaefer@xxxxxxx
On Mar 7, 6:23pm, gwing@xxxxxxxxxxxxxxx wrote:
} Subject: Zle patch - termok change
} termok now is flag based, not value based.
} termok == 0 indicates a `normal' working terminal - this is *opposite* to
} the previous situation.
In that case, you should never use the form (!termok) because it reads as
if you mean the terminal is not OK. Use (termok == 0) or make a new macro
#define nosetflag(X) ((X) == 0)
and then write (nosetflag(termok)).
} Flags for termok are defined and explained in zsh.h - currently TERM_NARROW
} is unused.
It looks like it is used in zlevarsetfn() ... you mean nobody explicitly
tests for it, but it is used in the sense that it makes termok != 0 ...
} If a terminal is evaluated as TERM_BAD then that status shouldn't go until
} $TERM is changed.
So that means that init_term() looks for TERM_BAD and doesn't change it?
} Bart wrote:
} :Hmm. Well, I dislike ..... because it presumes that init_term()
} :is independent of the values of "lines" and "columns".
} I can't see why lines/columns should be any way connected to init_term() .
They don't need to be as long as init_term() doesn't reset TERM_SHORT or
TERM_NARROW. If I do
Then what happens to termok? Am I going to get a crash because init_term()
has reset termok to zero?
#define issetflag(X, Y) ((X & (Y)) == Y)
#define isanysetflag(X, Y) (X & (Y))
Is it really necessary for these to be different? Why risk evaluating Y
twice in issetflag?
Bart Schaefer Brass Lantern Enterprises
Messages sorted by: