PATCH: 3.1.5-pws-8: setting duplicate elements of assoc array

[Peter Stephenson <pws@xxxxxxxxxxxxxxxxx>]

I just discovered:

% typeset -A newhash
% newhash=(a 1 a 2)
<SPLAT!>

This is because createparam() now returns NULL when the parameter already
exists.  The easiest fix is to allow the later value to override the
former.

While doing this, I discovered two other bugs which I haven't fixed:

1)
% __foo() { local list; list=(a b); complist -y '$list' -k list; }
% defcomp __foo foo
% foo ^D
<random junk printed>

I don't know if it's supposed to work when list is about to go out of
scope, and there's an easy workaround `-y "($list)"' (provided $list
doesn't have spaces or commas --- which it actually does in the case I was
trying, so I seem to be stuck), but it shouldn't print what it did.

2)
% print ${foo%% 
                ^ cursor here after space, hit tab, gives
% print ${foo%% BUG: inbrace == '{' in paramsubst()
BUG: inbrace == '{' in paramsubst()
% print ${foo%% 


--- Src/params.c.uass	Thu Feb 18 11:57:31 1999
+++ Src/params.c	Thu Feb 18 17:49:26 1999
@@ -1837,6 +1837,12 @@
     while (*aptr) {
 	/* The parameter name is ztrdup'd... */
 	v->pm = createparam(*aptr, PM_SCALAR|PM_UNSET);
+	/*
+	 * createparam() doesn't return anything if the parameter
+	 * already existed.
+	 */
+	if (!v->pm)
+	    v->pm = (Param) paramtab->getnode(paramtab, *aptr);
 	zsfree(*aptr++);
 	/* ...but we can use the value without copying. */
 	setstrvalue(v, *aptr++);

-- 
Peter Stephenson <pws@xxxxxxxxxxxxxxxxx>       Tel: +39 050 844536
WWW:  http://www.ifh.de/~pws/
Dipartimento di Fisica, Via Buonarroti 2, 56127 Pisa, Italy