Re: Anybody know what's going on in xsymlinks()? [utils.c]

["Bart Schaefer" <schaefer@xxxxxxxxxxxxxxxxxxxxxxx>]

On Jul 14,  4:47am, Bart Schaefer was talking to himself again:
} Subject: Anybody know what's going on in xsymlinks()?  [utils.c]
}
} [...]
} so either this is something that Zefram privately added to 3.1.2 or so, or
} else the 3.0.5 code is an old change that didn't get propagated into 3.1.x.

On closer examination it *appears* that the 3.1.x code may be intended to
fix a memory leak, but really may have introduced a different bug.

In 3.0.x, xsymlinks() is treated as if it returns a boolean, but in fact
it's impossible AFAICT for it ever to return anything but 0.  (That means
that the apparent memory leak really wasn't one, so the fix may not have
been necessary.)

In 3.1.x, xsymlinks() returns 1 whenever it has called itself recursively,
and returns 0 otherwise.

Any clues as to what is and/or should be going on in this function would be
appreciated.

-- 
Bart Schaefer                                 Brass Lantern Enterprises
http://www.well.com/user/barts              http://www.brasslantern.com