Re: PATCH: new parameter flag?

[Sven Wischnowsky <wischnow@xxxxxxxxxxxxxxxxxxxxxxx>]

Zefram wrote:

> Sven Wischnowsky wrote:
> >+	opts[PROMPTPERCENT] = 1;
> >+	if (presc < 2)
> >+	    opts[PROMPTSUBST] = opts[PROMPTBANG] = 0;
> 
> No, that's nasty.  I can see a need for % expansion, and I can see
> a need for prompt expansion, but prompt expansion with % sequences
> unconditionally enabled?  If the user wants something so obscure, they
> can twiddle the options themselves.  Make the above
> 
> 	if (presc < 2) {
> 	    opts[PROMPTPERCENT] = 1;
> 	    opts[PROMPTSUBST] = opts[PROMPTBANG] = 0;
> 	}

Hm, yes, I was lead to this mainly by the `name' of the flag.

Bye
 Sven

--- os/subst.c	Tue Aug 31 14:40:29 1999
+++ Src/subst.c	Tue Aug 31 14:40:34 1999
@@ -1662,9 +1662,10 @@
 	int ops = opts[PROMPTSUBST], opb = opts[PROMPTBANG];
 	int opp = opts[PROMPTPERCENT], len;
 
-	opts[PROMPTPERCENT] = 1;
-	if (presc < 2)
+	if (presc < 2) {
+	    opts[PROMPTPERCENT] = 1;
 	    opts[PROMPTSUBST] = opts[PROMPTBANG] = 0;
+	}
 	if (isarr) {
 	    char **ap;
 
diff -u od/Zsh/expn.yo Doc/Zsh/expn.yo
--- od/Zsh/expn.yo	Tue Aug 31 14:41:26 1999
+++ Doc/Zsh/expn.yo	Tue Aug 31 14:42:15 1999
@@ -606,8 +606,8 @@
 Expand all tt(%) escapes in the resulting words in the same way as in
 prompts (see noderef(Prompt Expansion)). If this flag is given twice,
 full prompt expansion is done on the resulting words, depending on the 
-setting of the tt(PROMPT_SUBST) and tt(PROMPT_BANG) options. The
-tt(PROMPT_PERCENT) option is temporarily turned on in any case.
+setting of the tt(PROMPT_PERCENT), tt(PROMPT_SUBST) and
+tt(PROMPT_BANG) options.
 )
 item(tt(X))(
 With this flag parsing errors occuring with the tt(Q) flag or the

--
Sven Wischnowsky                         wischnow@xxxxxxxxxxxxxxxxxxxxxxx