Re: PATCH: RE: _make error

[Sven Wischnowsky <wischnow@xxxxxxxxxxxxxxxxxxxxxxx>]

Andrej Borsenkow wrote:

> > In Zsh top level directory (gmake is GNU make)
> >
> > sudo gmake install.moTAB
> >
> > resulted in (long long - already scrolled away)
> >
> > ........
> >
> > make: Fatal error: don't know how to make .PHONY (bu42).
> > dules
> 
> It called ``make'' instead of $words[1]. Patch attached because of line
> length as usual.

The patch below contains Andrej's change and some more from me.

It should *at least* use _call. And I'm *very* tempted to add a style
to keep it from calling make even when it's a GNU make. Somehow I was
asleep when this was added, it seems, although I remember that there
was a lot of discussion.

Heck, doing `make <TAB>' just made it run config.status or
something. That's *completely* unacceptable.

Bye
 Sven

Index: Completion/User/_make
===================================================================
RCS file: /cvsroot/zsh/zsh/Completion/User/_make,v
retrieving revision 1.6
diff -u -r1.6 _make
--- Completion/User/_make	2000/04/25 04:50:53	1.6
+++ Completion/User/_make	2000/04/27 12:41:35
@@ -33,7 +33,7 @@
 
   if [[ -n "$file" ]] && _tags targets; then
     if [[ -n "$_is_gnu[$words[1]]" ]]; then
-      tmp=( $(make -nsp --no-print-directory -f "$file" .PHONY | awk '/^[a-zA-Z0-9][^\/\t=]+:/ {print $1}' FS=:) )
+      tmp=( $(_call targets "$words[1]" -nsp --no-print-directory -f "$file" .PHONY 2> /dev/null | awk '/^[a-zA-Z0-9][^\/\t=]+:/ {print $1}' FS=:) )
     else
       tmp=(
             $(awk '/^[a-zA-Z0-9][^\/\t=]+:/ {print $1}

--
Sven Wischnowsky                         wischnow@xxxxxxxxxxxxxxxxxxxxxxx