RE: PATCH: _expand, _expand_word, and their doc

[Sven Wischnowsky <wischnow@xxxxxxxxxxxxxxxxxxxxxxx>]

Andrej Borsenkow wrote:

> ...
>
> > I don't, however, like to put it only into a bindable command, because
> > then people can't configure it to get all completions with, say, a
> > numeric prefix and TAB. And just adding a bindable command that makes
> > all completions be inserted when we have a completer for it is simple
> > (or just documenting the trick with _generic).
> 
> Well, it is a matter of taste.

For me it's mostly a matter of allowing more ways to configure the thing.

> I prefer to get a list first and then decide if
> I want to insert it. It takes exactly the same amount of keystrokes; does it
> make any difference between 'ESC-1-TAB' and 'TAB-^X-i'? Implementing this
> needs a bit more than just wrapper around completer but does not need any
> extra C-code at all (almost - issue with menu-selection remains).

I forgot: that re-use old list striked me as sensible, too, so I agree 
that we should allow it somehow. Either with a style in the completer
itself, or, maybe, in _oldlist. With the old-list style set to `all'
or some such.

> Question to Sven - with noautolist, noautomenu - which value
> compstate[old_list] has after the first TAB? Is list still generated and kept
> internally even if it is not shown?

Of course. The code just delays freeing the old list until after the
new one has been created and accepted (by compstate[old_list] != keep).

> > So, does that thing with allowing completions added separately to be
> > offered together with a string with all completions sound too esoteric
> > or do you really like it. And should we then put it into _complete? (I
> > mean, the weekend is coming up, so I should have the time to try to
> > implement it... ;-)
> 
> I probably won't use it, but won't object, of course.

I already decided to play a bit to see how difficult to implement this 
is (both in C and shell code).

Bye
 Sven


--
Sven Wischnowsky                         wischnow@xxxxxxxxxxxxxxxxxxxxxxx