Zsh Mailing List Archive Messages sorted by: Reverse Date, Date, Thread, Author

PATCH: "limit" should not set a limit to 0 on bad input

X-seq: zsh-workers 16111
From: Bart Schaefer <schaefer@xxxxxxxxxxxxxxxx>
To: zsh-workers@xxxxxxxxxx
Subject: PATCH: "limit" should not set a limit to 0 on bad input
Date: Mon, 22 Oct 2001 15:04:35 +0000
Mailing-list: contact zsh-workers-help@xxxxxxxxxx; run by ezmlm

Remind me again why "limit" doesn't understand a spec of "unlimited"?

Index: Src/Builtins/rlimits.c
===================================================================
--- Src/Builtins/rlimits.c	2001/04/09 20:14:13	1.1.1.1
+++ Src/Builtins/rlimits.c	2001/10/22 15:01:09
@@ -332,7 +332,12 @@
 	} else if (limtype[lim] == ZLIMTYPE_NUMBER || limtype[lim] == ZLIMTYPE_UNKNOWN) {
 	    /* pure numeric resource -- only a straight decimal number is
 	    permitted. */
-	    val = zstrtorlimt(s, &s, 10);
+	    char *t = s;
+	    val = zstrtorlimt(t, &s, 10);
+	    if (s == t) {
+		zwarnnam("limit", "limit must be a number", NULL, 0);
+		return 1;
+	    }
 	} else {
 	    /* memory-type resource -- `k' and `M' modifiers are permitted,
 	    meaning (respectively) 2^10 and 2^20. */

-- 
Bart Schaefer                                 Brass Lantern Enterprises
http://www.well.com/user/barts              http://www.brasslantern.com

Zsh: http://www.zsh.org | PHPerl Project: http://phperl.sourceforge.net

Messages sorted by: Reverse Date, Date, Thread, Author