Zsh Mailing List Archive
Messages sorted by: Reverse Date, Date, Thread, Author

RE: PATCH: fix for autoloading and compiling under Cygwin

> I was actually overlooking writing of zwc files in my first fix.
Here's a
> new patch that really fixes the problem, with a test case, too. I've
> two things here:
> * I added the O_BINARY flag to all calls to 'open' on zwc files.

That is needed in any case and is not harmful at all. Any system that
does not support this flag? Should probably add

#ifndef O_BINARY
#define O_BINARY 0

somewhere in ... zsh.h?

> * For text files, I changed the code to treat the result of 'seek' as
> upper bound on the length of the file. For the actual length, the
> value of 'read' is used. Checks that 'seek' and 'read' return the same
> have been changed to check that 'seek' and 'read' both return
> values.

I have mixed feelings about it. It needed to be under #ifdef __CYGWIN__
in the first place. It also defeats error checking completely.

Have you looked how bash on Cygwin does it?


Messages sorted by: Reverse Date, Date, Thread, Author