Zsh Mailing List Archive
Messages sorted by: Reverse Date, Date, Thread, Author

Re: Bug in history changes

Peter Stephenson wrote:
> It seems to be the code with HISTEXPIREDUPSFIRST in
> putoldhistentryontop() setting the next pointer to something that's
> about to be free, but I don't remotely understand the code well enough
> to be sure.  I made it go away by setting next to NULL if it was
> pointing to something that was being freed, but I have no idea if this
> is correct, or if that should ever happen.

Actually, I can't really see how the following fix can be far wrong.  It
fixes the crash.  It doesn't fix the other, very minor, problem.

Index: Src/hist.c
RCS file: /cvsroot/zsh/zsh/Src/hist.c,v
retrieving revision 1.42
diff -u -r1.42 hist.c
--- Src/hist.c	20 Feb 2002 19:25:14 -0000	1.42
+++ Src/hist.c	22 Feb 2002 11:24:54 -0000
@@ -941,6 +941,8 @@
 	hist_ring->down = he->down->up = he;
     hist_ring = he;
+    if (next == hist_ring)
+	next = hist_ring->down;

Peter Stephenson <pws@xxxxxxx>                  Software Engineer
CSR Ltd., Science Park, Milton Road,
Cambridge, CB4 0WH, UK                          Tel: +44 (0)1223 392070

The information transmitted is intended only for the person or
entity to which it is addressed and may contain confidential 
and/or privileged material. 
Any review, retransmission, dissemination or other use of, or
taking of any action in reliance upon, this information by 
persons or entities other than the intended recipient is 
If you received this in error, please contact the sender and 
delete the material from any computer.

Messages sorted by: Reverse Date, Date, Thread, Author