Zsh Mailing List Archive
Messages sorted by: Reverse Date, Date, Thread, Author

Re: default tag-order (was Re: zsh 4.2.1-test-A)



I wrote:
> 
> One safe option is to insert `(( ! ${@[(I)options]} )) ||'.
> That checks if there is an options tag before applying the tag-order.

Unless anyone objects, I'll commit this as a temporary solution. Actual
patch is below. It is the one solution which, as far as I know, doesn't
break anything that isn't already broken (which is what I meant by
"safe" above). So at least _cdrecord can be fixed and this needn't hold
up 4.2.1.

As a longer term fix, that default tag-order has to go completely. I
just need to find all those things that removing it would break and find
a better fix.

Oliver

Index: Completion/Base/Core/_tags
===================================================================
RCS file: /cvsroot/zsh/zsh/Completion/Base/Core/_tags,v
retrieving revision 1.3
diff -u -r1.3 _tags
--- Completion/Base/Core/_tags	29 May 2001 17:54:08 -0000	1.3
+++ Completion/Base/Core/_tags	8 Aug 2004 13:52:56 -0000
@@ -41,6 +41,7 @@
     "$_sort_tags" "$@"
   else
     zstyle -a ":completion:${curcontext}:" tag-order order ||
+        (( ! ${@[(I)options]} )) ||
         order=('(|*-)argument-* (|*-)option[-+]* values' options)
 
     for tag in $order; do



Messages sorted by: Reverse Date, Date, Thread, Author