Re: down-line-or-search doesn't go to last entry

["Mikael Magnusson" <mikachu@xxxxxxxxx>]

2008/5/11 Peter Stephenson <p.w.stephenson@xxxxxxxxxxxx>:
>
> On Sun, 11 May 2008 16:23:54 +0200
>  "Mikael Magnusson" <mikachu@xxxxxxxxx> wrote:
>  > I have {up,down}-line-or-search bound to Up/Down, and I noticed
>  > recently that down-line-or-search won't go to the empty entry anymore.
>  > Ie if you press up and then down, it will still have the previous
>  > entry in the cmdline, I have to press page down where I have
>  > down-history to get back to the empty line.
>
>  I have been annoying myself silly with this over yet another two hours
>  of my life that will never come again.
>
>  There is one bug in zlinecmp() that I've recently introduced.
>
>  However, I don't think that's the main problem, which is the second test
>  for whether a search line is acceptable.  In recent versions of the
>  shell, the test has been looking to ensure the search text *differs*
>  from the line you're trying it against, which obviously doesn't make
>  sense.  It was already doing something such in 4.2.  This is complicated
>  by the fact that until I changed it to using metafied strings the
>  comparisons were being done in interesting ways which have changed
>  subtly over the shell's history (though I haven't gone back before 4.2).
>  The upshot seems to be the test previously fortuitously failed due to
>  the fact that it was being passed the length of the current editing
>  line, not the length of the search string.
>
>  I am guessing that the real point of this second test is to compare if
>  the line is different from the one you've just left, and hence it
>  shouldn't involve the search string at all, just the line you're leaving
>  and the line you're trying.  Those more energetic may wish, as an
>  exercise, to compare with the archive.
>
>  Let's see how this works.

That appears to fix the problem here, thanks.

-- 
Mikael Magnusson