Zsh Mailing List Archive
Messages sorted by: Reverse Date, Date, Thread, Author

PATCH: vcs_info: Set NO_warn_create_global option

I wanted to do the following, because I'd like to have
`check-for-changes' set in my own project directories, but not in
others, I just check out (because it can be slow for big repos):

function estyle-cfc() {
    local d
    local -a cfc_dirs
    cfc_dirs=( ${HOME}/src/code/*(/) )

    for d in ${cfc_dirs}; do
        [[ $PWD == $d(|/*) ]] && return 0
    return 1

zstyle -e ':vcs_info:git:*' \
    check-for-changes 'estyle-cfc && reply=( true ) || reply=( false )'

That however, welcomes me with this nice warning:
VCS_INFO_get_data_git:49: array parameter reply created globally in function

In theory the above should work (and it does except for the warning). It
also works in compsys, where I'm using this:

zstyle -e ':completion:*:approximate:*' \
    max-errors 'reply=( $(( ($#PREFIX + $#SUFFIX) / 3 )) )'

What compsys does is, it disables the warn_create_global option while
it's running.

While I like what the option does (prevent me from cluttering the shell
with all sorts of variables if I forget `local'), I still want to be
able to use `-e' with zstyle.

So, there are three options:
 a) Get the big hammer and just disable `warn_create_global' in
 b) Use a smaller hammer, and create a wrapper function around zstyle
    for vcs_info, that disables the option locally.
 c) Disable `warn_create_global' in code executed by "zstyle -e". Or
    make `reply' and `REPLY' special in that case. Or whatever makes the
    most sense.

This patch does what "a)" suggests, basically because it works and I was
lazy. I think "c)" would be the cleanest solution, but I don't know if
that's doable and I haven't looked at the involved code yet.

I might implement "b)" at a later date if "c)" is not feasilbe with
reasonable effort.

Regards, Frank
 Functions/VCS_Info/vcs_info |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/Functions/VCS_Info/vcs_info b/Functions/VCS_Info/vcs_info
index 906d984..a9e65e1 100644
--- a/Functions/VCS_Info/vcs_info
+++ b/Functions/VCS_Info/vcs_info
@@ -40,7 +40,7 @@ vcs_info_setsys
 # and now, finally create the real vcs_info function
 vcs_info () {
     emulate -L zsh
-    setopt extendedglob
+    setopt extendedglob NO_warn_create_global
     [[ -r . ]] || return 0

Messages sorted by: Reverse Date, Date, Thread, Author