Zsh Mailing List Archive
Messages sorted by: Reverse Date, Date, Thread, Author

Re: coredump on C-c

On Sep 26,  8:49pm, Bart Schaefer wrote:
} For example, there may be a performance hit for queuing signals around
} all the hash table traversals in the add* and scan* functions.  If we
} assume restartable syscalls that's probably OK for scan

By "that's" I mean "NOT queuing signals there is" in case that wasn't

It occurs to me, though, that queuing signals all over hashtable.c may
be an over-reaction.  Maybe the problem is just with re-entering the
endparamscope() routine, and that's where queue_signals() is needed.

Which is a much smaller change, and probably harmless even if it does
not help:

diff --git a/Src/params.c b/Src/params.c
index 8649178..d6711e4 100644
--- a/Src/params.c
+++ b/Src/params.c
@@ -4667,10 +4667,12 @@ startparamscope(void)
 mod_export void
+    queue_signals();
     /* This pops anything from a higher locallevel */
     saveandpophiststack(0, HFILE_USE_OPTIONS);
     scanhashtable(paramtab, 0, 0, 0, scanendscope, 0);
+    unqueue_signals();

Messages sorted by: Reverse Date, Date, Thread, Author