Zsh Mailing List Archive
Messages sorted by: Reverse Date, Date, Thread, Author

Re: PATCH: get-line shouldn't set histline



On Wed, 12 Aug 2015 16:26:47 +0200
Oliver Kiddle <okiddle@xxxxxxxxxxx> wrote:
> The get-line widget is
> meant to insert the line from the buffer stack into the current line.
> Changing histline without setting the line to correspond to the text
> stored for the history entry results in undo information that doesn't
> make sense.

Yes, I think this is just because the code was copied from the case
where the line is being set when the line editor starts.  In that case
popping the line gives you the history context around where you pushed
it.  get-line seems like it should just grab the string and keep the
current context.  But most of the times I use get-line it doesn't
actually matter, so I can't swear this is always right.

pws



Messages sorted by: Reverse Date, Date, Thread, Author