Zsh Mailing List Archive
Messages sorted by: Reverse Date, Date, Thread, Author

Re: Is "command" working right, yet?

Op 27-09-16 om 11:08 schreef Peter Stephenson:
> On Sun, 25 Sep 2016 20:13:28 -0700
> Bart Schaefer <schaefer@xxxxxxxxxxxxxxxx> wrote:
>> A complication is that "command -v" is defined in terms of bin_whence(),
>> and "whence" has a -p option that means something different.
> That also means path search.


'command -p' means: ignore the PATH environment variable and do the
search as normal, but (if it's a path search) use the system default
path as output by the 'getconf PATH' command. That means the -p option
has no effect for builtins.

POSIX provides this as one way to make shell scripts a bit more robust;
'command -p grep' guarantees you get either the system's external 'grep'
or a builtin version provided by the shell, and not some other 'grep'
that the user (or someone who hacked them) may have installed in some
location that comes before the real 'grep' in $PATH and that may, for
all anyone knows, delete all their files.


This is why it's important that '-p' should combine properly with '-v'
and '-V'. The command 'command -pv grep', provided there is no builtin
for it, should output the location of the system default 'grep' as
opposed to whatever 'grep' may take precedence over it in $PATH.

By the way, 'command -p' *nearly* works properly (i.e. as described
above) in zsh, apart from combining with other options. See line 664 and
on in exec.c, line 2030 and on in configure.ac, and line 77 in config.h.in.

The problem is configure.ac only tries non-standard 'getconf' commands
(i.e. 'getconf _CS_PATH' and 'getconf CS_PATH'); the command to use on
BSD/OSX is 'getconf PATH', which works on Linux as well. I don't know if
the other two should be kept, but 'getconf PATH' should at least be added.

diff --git a/configure.ac b/configure.ac
index 0e0bd53..e0eb320 100644
--- a/configure.ac
+++ b/configure.ac
@@ -2035,6 +2035,8 @@ AC_CACHE_VAL(zsh_cv_cs_path,
   zsh_cv_cs_path=`getconf _CS_PATH`
 elif getconf CS_PATH >/dev/null 2>&1; then
   zsh_cv_cs_path=`getconf CS_PATH`
+elif getconf PATH >/dev/null 2>&1; then
+  zsh_cv_cs_path=`getconf PATH`


- M.

Messages sorted by: Reverse Date, Date, Thread, Author