Zsh Mailing List Archive
Messages sorted by:
Re: Bug#844710: Fwd: Re: [Pkg-zsh-devel] Bug#844710: autocorrection suggested rm for typing mr without typing "y"
- X-seq: zsh-workers 39987
- From: Bart Schaefer <schaefer@xxxxxxxxxxxxxxxx>
- To: zsh-workers@xxxxxxx
- Subject: Re: Bug#844710: Fwd: Re: [Pkg-zsh-devel] Bug#844710: autocorrection suggested rm for typing mr without typing "y"
- Date: Sat, 19 Nov 2016 10:00:23 -0800
- Cc: 844710@xxxxxxxxxxxxxxx
- Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=brasslantern-com.20150623.gappssmtp.com; s=20150623; h=from:message-id:date:in-reply-to:comments:references:to:subject:cc :mime-version; bh=vbQVxY0uVkfixsXa1znOsJdCaEilRxsWhxUeNQS4D0s=; b=UckoGZULYCz/5SRGpWy7+vjqrk/uiF6Zvw+KAWayh7qffQ4U/hBNzeHJYSBWEmmrFR NmsH5WrhWOTSZ8GhLKBiU9kMRnHBWlRB1f2j2ZebZB53JEZBW3nzVOWVGH+E3MxhMuOM tc1YBmygymct2HPoZGi/iquWd6uIw+LbLBtC/2Kc4/2opyq1mF+AoQ4aEUrCn0Yrmws4 xbvpL4y8cbGbIaVh4uRZxndcu/NvKgdvIQKsmV75io+5sYWjmbFpn0AquxUk4I1OzkEa LODuId0ENlSvm8RHo44Mu8bpTEsN7VlpAfpWzSXhIkIWZkDjhv8hnuudNO5MuIUAKoJ1 pSQw==
- In-reply-to: <20161119075542.GA6750@fujitsu.shahaf.local2>
- List-help: <mailto:firstname.lastname@example.org>
- List-id: Zsh Workers List <zsh-workers.zsh.org>
- List-post: <mailto:email@example.com>
- Mailing-list: contact zsh-workers-help@xxxxxxx; run by ezmlm
- References: <3574167.p9ErITdPmY@merkaba> <20161119075542.GA6750@fujitsu.shahaf.local2>
On Nov 19, 7:55am, Daniel Shahaf wrote:
} Subject: Re: Bug#844710: Fwd: Re: [Pkg-zsh-devel] Bug#844710: autocorrecti
} Martin Steigerwald wrote on Fri, Nov 18, 2016 at 14:15:51 +0100:
} > So two fixes to consider:
} > 1) Don't confirm on space, as thats to easy to trigger accidentally. :)
} The code confirms on both tabs (since commit 7f1ce570) and spaces (since
} before CVS). Does anyone know a reason for doing this?
If you have a look at the zsh-workers article referenced by 7f1ce570,
you'll see that both space and tab date from time immemorial; the patch
in 7f1ce570 actually REMOVES the interpretation of tab as "yes" from
the NO_RM_STAR_SILENT option, it didn't change CORRECT handling.
Why it's this way probably has more to do with Paul Falstad's typing
habits than anything else. If you're used to hitting space or tab at
a completion, and most of the time you believe the correction, then
you probably want space and tab to mean "go ahead" anytime the shell
is waiting for something.
Notice the RM_STAR_WAIT option for a similar situation.
While I don't use CORRECT and therefore personally don't much care
what this prompt does, I question whether one person remarking about
this after 25+ years of it being the way it has been, is a sufficient
reason for us to immediately change it.
Messages sorted by: