Re: [PATCH] 2 modules, zsh/db, zsh/gdbm, bug-fixes

[Sebastian Gniazdowski <psprint@xxxxxxxxxxx>]

On 24 czerwca 2017 at 05:53:12, Bart Schaefer (schaefer@xxxxxxxxxxxxxxxx) wrote:
> Yes, I would also prefer the vim folding be removed, and the use of
> CamelCapsVariableNames be made more like the rest of the code, but
> both of those seemed unnecessarily picky.

The folding helps in redis module, where set of GSU objects is devoted to 6 different types.

> } The #if 0 looks alarming.
> 
> It's around code that was never present in db_gdbm.c before, and protects
> a function call that's "new" (in a historical sense) to the library. I
> think it's also nothing but an optimization, and therefore not essential.

I've reported bug report to GDBM (before writing [PATCH] mail). Got response with correct address to send the report. The problem is: gdbm_reorganize doesn't work correctly on NFS filesystems. Short test code:

https://github.com/zdharma/hacking-private/tree/master/gdbm

Effect on NFS:

https://asciinema.org/a/ocjBIM9sEcvnNovA9AkStSwsQ

> I've had a hard time deciding which of the warning functions is the
> right one to use in a given situation. zwarnnam() is usually meant to
> prefix the message with the name of a command that caused the error;
> it's not obvious that it should be used in a context where there is no
> command involved. (I haven't dug into whether that is the case for
> the instances you've called out.)

Yes me too had hard time deciding on this. I can add some names, no problem.

-- 
Sebastian Gniazdowski
psprint /at/ zdharma.org