Zsh Mailing List Archive
Messages sorted by: Reverse Date, Date, Thread, Author

Re: RFC: [PATCH] Completion/Unix/Command/_git: replace a few "*::" with "*:"

On 24 Feb 2019, at 07:58, Daniel Hahler <genml+zsh-workers@xxxxxxxxxx> wrote:
>This patch changes some of the "*::" to "*:", but is not really tested
>in detail.  Mostly based on trying if "--help" worked after any arg.

Some of these do look like they were just erroneously copied and pasted, but
in other cases it's actually necessary, at least with the way it's written
now. For example, the commit-range-or-file state checks to see if $CURRENT is
1, which can only ever be true if the *:: syntax (or equivalent) is used.

I didn't look at it much harder than that, but, in general, anywhere you're
thinking about removing *:: or *:::, you need to check the corresponding state
code to see if it does anything with $words or $CURRENT, or calls another
function that does.

dana
Messages sorted by: Reverse Date, Date, Thread, Author