Zsh Mailing List Archive
Messages sorted by:
Reverse Date,
Date,
Thread,
Author
Re: [PATCH] {,un}applychange: do not call zle_setline(NULL) if quietgethist() fails
- X-seq: zsh-workers 44461
- From: Oliver Kiddle <okiddle@xxxxxxxxxxx>
- To: Kamil Dudka <kdudka@xxxxxxxxxx>
- Subject: Re: [PATCH] {,un}applychange: do not call zle_setline(NULL) if quietgethist() fails
- Date: Fri, 28 Jun 2019 01:01:25 +0200
- Authentication-results: amavisd4.gkg.net (amavisd-new); dkim=pass (2048-bit key) header.d=yahoo.co.uk
- Cc: zsh-workers@xxxxxxx
- Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.co.uk; s=s2048; t=1561676489; bh=R9YUTKblw/J+A+hLWLJPDKJ5JTo8+VDkEDV7n9DLwB8=; h=From:References:To:Subject:Date:From:Subject; b=o4OHfdGDBrBM0Z52SJt5z4fwtv1E1d6hVOetw9qxzXcA8NKVGr3zBgLBWs/Cn9/TIij0emuo3R562mxrMnXmZbEHjNeQ0du9uUUm6IyEYxdtY3wC1PX8sXKnnV3wFNoKNMVCVLK6QUwHx6PWhOgHiHjm0rAhcuPZaGGZW9ko0oHEDyAvFGZ1UqSmi0h5l0bLUXwAtPQJnp69AqloFeSNReOKInA9r6JxzcueRu123Bop4yGKyWv5o+bd5SCyNT++4dhFXBfXONT7uzIrxUzQitXOK7Nz3eCgbgC4xpXafdFDVPDaYs0TREGMKomxaaKeNdntWkG7kt4I2Rev5qVrBQ==
- In-reply-to: <20190626101908.548-1-kdudka@redhat.com>
- List-help: <mailto:zsh-workers-help@zsh.org>
- List-id: Zsh Workers List <zsh-workers.zsh.org>
- List-post: <mailto:zsh-workers@zsh.org>
- List-unsubscribe: <mailto:zsh-workers-unsubscribe@zsh.org>
- Mailing-list: contact zsh-workers-help@xxxxxxx; run by ezmlm
- References: <20190626101908.548-1-kdudka@redhat.com>
Kamil Dudka wrote:
> There is a bug report in Red Hat Bugzilla about zsh crashing on NULL
> pointer dereference: https://bugzilla.redhat.com/1722703
>
> I was not able to reproduce the crash myself but the attached patch
> should prevent zsh from crashing in this situation.
It'd perhaps be good to add a DPUTS call here because while it is good
not to crash the condition does perhaps indicate a bug and it'd be
better not to hide it completely. I can't reproduce the crash either but
there must be some plugins or url quoting magic going on here.
More details of the setup used by the user might help find the
underlying problem.
Oliver
Messages sorted by:
Reverse Date,
Date,
Thread,
Author