Zsh Mailing List Archive Messages sorted by: Reverse Date, Date, Thread, Author

Re: TR : Re : [BUG] Crash due to malloc call in signal handler

X-seq: zsh-workers 45022
From: Bart Schaefer <schaefer@xxxxxxxxxxxxxxxx>
To: Peter Stephenson <p.stephenson@xxxxxxxxxxx>
Subject: Re: TR : Re : [BUG] Crash due to malloc call in signal handler
Date: Fri, 13 Dec 2019 13:10:07 -0800
Cc: Zsh hackers list <zsh-workers@xxxxxxx>
In-reply-to: <1576258224.5214.31.camel@samsung.com>
List-help: <mailto:zsh-workers-help@zsh.org>
List-id: Zsh Workers List <zsh-workers.zsh.org>
List-post: <mailto:zsh-workers@zsh.org>
List-unsubscribe: <mailto:zsh-workers-unsubscribe@zsh.org>
Mailing-list: contact zsh-workers-help@xxxxxxx; run by ezmlm
References: <CGME20191213171028eucas1p2e7820377701008b2d05c898192b7c17e@eucas1p2.samsung.com> <569822988.994307929.1576256973462.JavaMail.root@zimbra62-e11.priv.proxad.net> <1576258224.5214.31.camel@samsung.com>

On Fri, Dec 13, 2019, 9:31 AM Peter Stephenson <p.stephenson@xxxxxxxxxxx>
wrote:

>
> If you're using the current git source, exec.c line 4673 has a call to
> fgetc(), which is indeed outside where signals are queued. ... The fix
> might be
> not to fdopen() the input file, but just read into a buffer with
> read().
>

Yeah, calling stdio routines with signals unblocked is not safe.  We should
be doing explicit memory management here.

>

References:
- TR : Re : [BUG] Crash due to malloc call in signal handler
  - From: Antoine C.
- Re: TR : Re : [BUG] Crash due to malloc call in signal handler
  - From: Peter Stephenson

Messages sorted by: Reverse Date, Date, Thread, Author