Zsh Mailing List Archive
Messages sorted by: Reverse Date, Date, Thread, Author

[PATCH] test: kill: Document why we use SIGURG



See discussion in workers/45460.
---
 Test/B11kill.ztst | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/Test/B11kill.ztst b/Test/B11kill.ztst
index 40dd99cd3..dc6bf9b89 100644
--- a/Test/B11kill.ztst
+++ b/Test/B11kill.ztst
@@ -60,6 +60,15 @@
 ?(eval):kill:2: not enough arguments
 
 # Regression tests: `kill ''` should not result in `kill 0`.
+#
+# We use SIGURG where an explicit sigspec can be provided as:
+#
+# 1. By default it's non-terminal, so even if we regress, we won't kill the
+#    test runner and other processes in the process group since we'll stop
+#    running this test before we get to the plain kill (and thus SIGTERM)
+#    cases;
+# 2. It's also unlikely to be sent for any other reason during the process
+#    lifetime, so the test shouldn't be flaky.
 
   (
     trap 'exit 11' URG
-- 
2.25.0



Messages sorted by: Reverse Date, Date, Thread, Author