Re: [PATCH] add new features and improvements to the "incarg" ZLE widget

[Bart Schaefer <schaefer@xxxxxxxxxxxxxxxx>]

On Sun, Feb 4, 2024 at 11:37 AM midchildan <git@xxxxxxxxxxxxxx> wrote:
>
> This brings numerous improvements to the incarg ZLE widget

Thanks for sending.  Remarks below, all minor.

> Vim's increment command jumps to the nearest integer after the cursor
> and increments it. I find this behavior very useful when combined with
> history-beginning-search-backward. So I made it possible to get this
> behavior by prefixing vi to the widget name.

Here you say "vi" and in the doc specifically "vim" but in fact any
prefix beginning with "vi" is accepted by the code, I think?

> +  if [[ "$WIDGET" == vi* ]]; then
> +    # jump to the nearest number after the cursor

Should probably be more precise.

> +++ b/Doc/Zsh/contrib.yo
> @@ -2620,12 +2620,30 @@ zle -N history-pattern-search-forward history-pattern-search)
> +By default, the target integer will be incremented by one. With a numberic

Typo: "numeric"

Thanks for including a test.