Zsh Mailing List Archive Messages sorted by: Reverse Date, Date, Thread, Author

Re: [PATCH] Fix crash on unset-through-nameref

X-seq: zsh-workers 52662
From: Bart Schaefer <schaefer@xxxxxxxxxxxxxxxx>
To: Zsh hackers list <zsh-workers@xxxxxxx>
Subject: Re: [PATCH] Fix crash on unset-through-nameref
Date: Mon, 4 Mar 2024 00:39:30 -0800
Archived-at: <https://zsh.org/workers/52662>
In-reply-to: <20240304062914.kn6wquvgog3lefom@chazelas.org>
List-id: <zsh-workers.zsh.org>
References: <CAH+w=7ayqWoufueuaHiCzjmzgHtv6VV0m7mEXoHn5nGq4pNOzg@mail.gmail.com> <20240304062914.kn6wquvgog3lefom@chazelas.org>

On Sun, Mar 3, 2024 at 10:29 PM Stephane Chazelas <stephane@xxxxxxxxxxxx> wrote:
>
> That shows an unset through a nameref in a different scope
> doesn't do a full unset

Try removing this line from the patch:

+    pm->node.flags |= PM_DECLARED;

If that works, it'll also require updating the test.

Follow-Ups:
- Re: [PATCH] Fix crash on unset-through-nameref
  - From: Stephane Chazelas

References:
- [PATCH] Fix crash on unset-through-nameref
  - From: Bart Schaefer
- Re: [PATCH] Fix crash on unset-through-nameref
  - From: Stephane Chazelas

Messages sorted by: Reverse Date, Date, Thread, Author